Fix: Correctly determine GMP 22.7 as supported protocol #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Add tests to make sure the detected protocol version and instance is correct for GMP 22.7. Also add tests for the expected next protocol version (`22.8`) and a possible far future version (`22.20`), which should adequately fall back to the latest current version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
+ Coverage 97.78% 97.82% +0.03%
==========================================
Files 73 73
Lines 5112 5114 +2
Branches 929 930 +1
==========================================
+ Hits 4999 5003 +4
+ Misses 76 75 -1
+ Partials 37 36 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjoernricks
added
the
patch release
bjoernricks
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adjust the handling of the remote GMP version to detect GMP 22.7 correctly as supported and set the correct
gmp_classinstead of issuing a confusingUserWarningand falling back toGMPv226Why
When parsing a
warnings.warn( <get_version_response status="200" status_text="OK"><version>22.7</version></get_version_response>, the following warning was displayed:References
#1212
Checklist